Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FindBin to ecosystem #443

Merged
merged 6 commits into from May 21, 2019
Merged

Add FindBin to ecosystem #443

merged 6 commits into from May 21, 2019

Conversation

lembark
Copy link
Contributor

@lembark lembark commented Mar 26, 2019

see https://gitlab.com/lembark/Perl6-FindBin

  • I agree to the usage of the META file as listed here.

  • I have a license field listed in my META file that is one of https://spdx.org/licenses

    • My license is not one of those found on spdx.org but I do have a license field.
      In this case make sure you have a license URL listed under support. See this example.
    • I don't have a license field. Yes, I understand this is not recommended.

META.list Outdated
@@ -853,3 +853,4 @@ https://raw.githubusercontent.com/tony-o/perl6-libcsv/master/META6.json
https://raw.githubusercontent.com/alabamenhu/Fluent/master/META6.json
https://raw.githubusercontent.com/bduggan/p6-Grammar-PrettyErrors/master/META6.json
https://raw.githubusercontent.com/ALANVF/P6TK/master/META6.json
https://gitlab.com/lembark/Perl6-FindBin/blob/master/META6.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to put the path to the raw JSON file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sanity check: The URL references the META6.json file?

wget and firefox both snag the JSON for me.

Q: What is wrong with the URL?
Q: Other than an https-link to the META6.json file, what do I need to include?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lembark excuse my butting in here randomly, but I've sent you two mails from one account and another from a different account and I'd like to hear whether they are arriving or getting lost. thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I see CPAN:lembark. If you upload your module to CPAN, then nothing needs to be changed in this repository. http://modules.perl6.org/ and zef will pick up your module automatically (although with some delay, up to 1 day I think).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexDaniel I have a question. Will http://modules.perl6.org and zef index this module if the META6.json is wrongly formatted or if any of the property in the file doesn't work? (like incorrect URL for the source-url property)?

@JJ
Copy link
Contributor

JJ commented Mar 26, 2019

There's an error with the source URL, even fixed. You need to do that yourself.

@ghost
Copy link

ghost commented Apr 19, 2019

@lembark Consider changing the git@gitlab.com:lembark/Perl6-FindBin.git to https://gitlab.com/lembark/Perl6-FindBin or similar for the source-url property. It seems the test won't accept SSH source url.

@JJ
Copy link
Contributor

JJ commented Apr 19, 2019 via email

@jonathanstowe
Copy link
Contributor

For reference the check-sources of Test::META would fail for git@gitlab.com:lembark/Perl6-FindBin.git as it is not a valid URI.

@JJ
Copy link
Contributor

JJ commented Apr 29, 2019

I have seen several new versions of this on CPAN. Should I close the PR?

@lembark
Copy link
Contributor Author

lembark commented May 16, 2019

At this point it should be working, I'd suggest grabbing whatever's most recent on CPAN.
I won't be updating this much going forward -- it seems to work at this point.

@lembark
Copy link
Contributor Author

lembark commented May 16, 2019

Q: What is this telling me about the '::'?
I don't find any double-colons in the json file...

Resolving deltas: 100% (121/121), done.

    ok 7 - name has a '::' rather than a hyphen (if this is intentional please pass :relaxed-name to meta-ok)
ok 2 - Project META file is good

@Altai-man
Copy link
Member

Altai-man commented May 16, 2019

Q: What is this telling me about the '::'?

The thing is, in Perl 6, distribution naming style "Foo::Bar" is preferred over "Foo-Bar", so this test checks absence of hyphens. Since your distribution name is a single piece(just "Foo", not "Foo::Bar"), it naturally doesn't have any hyphens.

@lembark
Copy link
Contributor Author

lembark commented May 21, 2019

OK... should I add a trailing hyphen to the name or is it reasonable to have the test check for a singly-named moule?

@lembark
Copy link
Contributor Author

lembark commented May 21, 2019

Sanity check: If the module is added to CPAN as "FindBin" will it be available for use? Or is zef only capable of acquiring files that are in the ecosystem file?

@lembark lembark merged commit 12c3d27 into Raku:master May 21, 2019
@Altai-man
Copy link
Member

OK... should I add a trailing hyphen to the name or is it reasonable to have the test check for a singly-named moule?

You don't need to do anything, the test is oked, if it is not, then it is definitely a bug. But your "ok 2 - Project META file is good" means META file is good enough.

Sanity check: If the module is added to CPAN as "FindBin" will it be available for use? Or is zef only capable of acquiring files that are in the ecosystem file?

Zef works with both CPAN and ecosystem file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants