New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FindBin to ecosystem #443
Conversation
META.list
Outdated
| @@ -853,3 +853,4 @@ https://raw.githubusercontent.com/tony-o/perl6-libcsv/master/META6.json | |||
| https://raw.githubusercontent.com/alabamenhu/Fluent/master/META6.json | |||
| https://raw.githubusercontent.com/bduggan/p6-Grammar-PrettyErrors/master/META6.json | |||
| https://raw.githubusercontent.com/ALANVF/P6TK/master/META6.json | |||
| https://gitlab.com/lembark/Perl6-FindBin/blob/master/META6.json | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to put the path to the raw JSON file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sanity check: The URL references the META6.json file?
wget and firefox both snag the JSON for me.
Q: What is wrong with the URL?
Q: Other than an https-link to the META6.json file, what do I need to include?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it needs to be this link: https://gitlab.com/lembark/Perl6-FindBin/raw/master/META6.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lembark excuse my butting in here randomly, but I've sent you two mails from one account and another from a different account and I'd like to hear whether they are arriving or getting lost. thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I see CPAN:lembark. If you upload your module to CPAN, then nothing needs to be changed in this repository. http://modules.perl6.org/ and zef will pick up your module automatically (although with some delay, up to 1 day I think).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlexDaniel I have a question. Will http://modules.perl6.org and zef index this module if the META6.json is wrongly formatted or if any of the property in the file doesn't work? (like incorrect URL for the source-url property)?
|
There's an error with the source URL, even fixed. You need to do that yourself. |
|
@lembark Consider changing the |
|
It will not pass the test, it will not be indexed.
|
|
For reference the |
|
I have seen several new versions of this on CPAN. Should I close the PR? |
|
At this point it should be working, I'd suggest grabbing whatever's most recent on CPAN. |
|
Q: What is this telling me about the '::'? Resolving deltas: 100% (121/121), done. |
The thing is, in Perl 6, distribution naming style "Foo::Bar" is preferred over "Foo-Bar", so this test checks absence of hyphens. Since your distribution name is a single piece(just "Foo", not "Foo::Bar"), it naturally doesn't have any hyphens. |
|
OK... should I add a trailing hyphen to the name or is it reasonable to have the test check for a singly-named moule? |
|
Sanity check: If the module is added to CPAN as "FindBin" will it be available for use? Or is zef only capable of acquiring files that are in the ecosystem file? |
You don't need to do anything, the test is
Zef works with both CPAN and ecosystem file. |
see https://gitlab.com/lembark/Perl6-FindBin
I agree to the usage of the META file as listed here.
I have a license field listed in my META file that is one of https://spdx.org/licenses
In this case make sure you have a license URL listed under support. See this example.