Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Ensure config.status and plain nqp binary are cleaned in realclean
  • Loading branch information
Paul Cochrane committed Apr 24, 2015
1 parent 08d257a commit 667a3f7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/build/Makefile-Moar.in
View file
Expand Up @@ -66,7 +66,7 @@ release: manifest
distclean: realclean

realclean: clean
$(RM_F) Makefile MANIFEST
$(RM_F) Makefile MANIFEST config.status nqp

testclean:

Expand Down

3 comments on commit 667a3f7

@coke
Copy link
Contributor

@coke coke commented on 667a3f7 Apr 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the literal nqp here might want to be nqp$(BAT)

@FROGGS
Copy link
Contributor

@FROGGS FROGGS commented on 667a3f7 Apr 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no nqpat all, it is nqp-{m,j,p}$(BAT) or so

@paultcochrane
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right at the end of the make step, the following commands are executed (on Linux, building with MoarVM):

/path/to/perl -MExtUtils::Command -e cp nqp-m nqp
/path/to/perl -MExtUtils::Command -e chmod 755 nqp

This seems to be part of the m-runner-default: target. Thus a file nqp is generated as part of the build.

@coke: I believe you're right; it should be nqp$(BAT) or something similar.

Please sign in to comment.