Detect undeclared attributes at compile time and complain about them.…

… Possible now that we register them with the compile timemeta-object. Also, pass any declared type along to the PAST::Var node, though it's not used yet.
Raku · Apr 26, 2011 · eafc258 · eafc258
1 parent 1a79be7
commit eafc258
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 2 deletions.
diff --git a/src/NQP/Actions.pm b/src/NQP/Actions.pm
@@ -435,12 +435,32 @@ class NQP::Actions is HLL::Actions {
                 );
             }
             elsif $<twigil>[0] eq '!' {
+                # Construct PAST.
+                my $name := ~@name.pop;
                 $past := PAST::Var.new(
-                    :name(~@name.pop), :scope('attribute'),
+                    :name($name), :scope('attribute'),
                     :viviself( vivitype( $<sigil> ) ),
                     PAST::Var.new( :name('self') ),
                     PAST::Var.new( :name('$?CLASS') )
                 );
+
+                # Make sure the attribute exists.
+                # XXX Can't check for knowhow yet.
+                unless $*IN_DECL || $*PKGDECL eq 'knowhow' {
+                    my $attr;
+                    for $*PACKAGE.HOW.attributes($*PACKAGE, :local(1)) {
+                        if $_.name eq $name {
+                            $attr := $_;
+                            last;
+                        }
+                    }
+                    if pir::defined($attr) {
+                        $past.type($attr.type);
+                    }
+                    else {
+                        $/.CURSOR.panic("Attribute '$name' not declared");
+                    }
+                }
             }
             elsif is_package(~@name[0]) {
                 $past := lexical_package_lookup(@name, $/);

diff --git a/src/NQP/Grammar.pm b/src/NQP/Grammar.pm
@@ -98,6 +98,8 @@ grammar NQP::Grammar is HLL::Grammar {
     ## Top-level rules
 
     token comp_unit {
+        :my $*IN_DECL := '';
+
         :my $*HAS_YOU_ARE_HERE := 0;
         :my $*MAIN_SUB;
         <.newpad>
@@ -394,7 +396,12 @@ grammar NQP::Grammar is HLL::Grammar {
         | <routine_declarator>
     }
 
-    rule variable_declarator { <typename>? <variable> }
+    rule variable_declarator {
+        <typename>?
+        :my $*IN_DECL := 'variable';
+        <variable>
+        { $*IN_DECL := 0; }
+    }
 
     proto token routine_declarator { <...> }
     token routine_declarator:sym<sub>    { <sym> <routine_def> }