Catch exceptions in VTABLE find_method #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This came from dukeleto++ wanting to find the real cause I was just patching over in parrot/parrot#239 |
The sixmodel VTABLE find_method calls the find_method in the containers STABLE which will throw instead of returning NULL if it can't find the method. Anything which is calling the VTABLE find_method is not going to be expecting an exception so catch any exception and return NULL.
|
UPDATED: Dropped the new VTABLE can, sorear++ pointed out that exceptions shouldn't be being thrown |
|
Hmm, it looks like this isn't good enough as an exception handler. I'm geting segfault's when I've intercepted an exception |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need this to get 'nqp --target=past -e 1' working again.