Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve pod panic msg #401

Merged
merged 1 commit into from Feb 11, 2018
Merged

improve pod panic msg #401

merged 1 commit into from Feb 11, 2018

Conversation

tbrowder
Copy link
Member

No description provided.

@AlexDaniel
Copy link
Member

@AlexDaniel AlexDaniel removed their request for review February 10, 2018 15:30
@tbrowder
Copy link
Member Author

I have the test file that shows the PR works, but at the moment it has to be executed manually by the generated nqp from this PR.

$ cat pod-test.nqp
=pod
text...
=cut

Execute the file:

$ ./nqp pod-test.nqp
Obsolete pod format (=pod/=cut), please use =begin/=end instead at line 5, near "\n"
   at gen/moar/stage2/NQPHLL.nqp:707  (NQPHLL.moarvm:panic)
 from gen/moar/stage2/NQP.nqp:876  (nqp.moarvm:)
...

Note the first line shows the desired improved panic msg.

See the gist https://gist.github.com/tbrowder/ec5ccce995e27b8f28fdf176ccb6e6a0 for the desired nqp wrapper test file and the resulting error.

@AlexDaniel AlexDaniel merged commit 0292b5a into Raku:master Feb 11, 2018
@tbrowder tbrowder deleted the mod-pod-panic-msg branch February 11, 2018 03:19
@tbrowder
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants