S17 is confused about callbacks and 'close' vs. 'done' and positional vs. named

[moritz]

S17 has these two examples:

$supply.tap: -> $value { say "Got a $value" },
    done => { say "Reached the end" },
    quit => {
        when X::FooBar { die "Major oopsie" };
        default        { warn "Supply shut down early: $_" }
    }

and

my $t2 = $s.tap({ say 2 * $_ },
                { say "End" });

The first one suggests that there is one positional parameter to Supply.tap, but the second implies two positionals. Which one is it?

Also it seems that Channels and Taps are closed, but Supplies are done. If this is intentional, it should be made abundantly clear what the semantic difference is.

[moritz]

@jnthn said on #perl6: Supply.done is for the producer to signal the end of the stream, .close is for the tap (not the supply) to indicate that it doesn't want more values.

By analogy, shutting down a channel should be done with Channel.done, IMHO.