Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5334cb725 causes erroneous sink on ($_ with "foo") #5476

Closed
p6rt opened this issue Jul 29, 2016 · 7 comments
Closed

5334cb725 causes erroneous sink on ($_ with "foo") #5476

p6rt opened this issue Jul 29, 2016 · 7 comments

Comments

@p6rt
Copy link

@p6rt p6rt commented Jul 29, 2016

Migrated from rt.perl.org#128770 (status was 'resolved')

Searchable as RT128770$

@p6rt
Copy link
Author

@p6rt p6rt commented Jul 29, 2016

From @LLFourn

say ($_ with "foo")

rakudo-moar aa5e49​: OUTPUT«WARNINGS for <tmp>​:␤Useless use of $_ in sink
context (line 1)␤Foo␤»

bisect output​:

https://gist.github.com/Whateverable/51a3b382dfecdad999b21db34ec1d26b

commit​:

rakudo/rakudo@5334cb7

@p6rt
Copy link
Author

@p6rt p6rt commented Jul 29, 2016

From @TimToady

The logical ops andthen, notandthen, and orelse were not propagating wantedness to their thunky args.

Fixed in 7ba6dbfae97f5ff9398336e49267d51606512df9.

Note that we don't generally test sink warnings currently.

1 similar comment
@p6rt
Copy link
Author

@p6rt p6rt commented Jul 29, 2016

From @TimToady

The logical ops andthen, notandthen, and orelse were not propagating wantedness to their thunky args.

Fixed in 7ba6dbfae97f5ff9398336e49267d51606512df9.

Note that we don't generally test sink warnings currently.

@p6rt
Copy link
Author

@p6rt p6rt commented Jul 29, 2016

@TimToady - Status changed from 'new' to 'resolved'

@p6rt
Copy link
Author

@p6rt p6rt commented Jul 29, 2016

@coke - Status changed from 'resolved' to 'open'

@p6rt
Copy link
Author

@p6rt p6rt commented Aug 3, 2016

From @LLFourn

Test​:
Raku/roast@4fdee95

On Sat, Jul 30, 2016 at 4​:55 AM Larry Wall via RT <
bugs-comment@​bugs6.perl.org> wrote​:

The logical ops andthen, notandthen, and orelse were not propagating
wantedness to their thunky args.

Fixed in 7ba6dbfae97f5ff9398336e49267d51606512df9.

Note that we don't generally test sink warnings currently.

@p6rt
Copy link
Author

@p6rt p6rt commented Aug 5, 2016

@smls - Status changed from 'open' to 'resolved'

@p6rt p6rt closed this Aug 5, 2016
@p6rt p6rt added the testneeded label Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant