∞.Rat ~~ Rat is False

[p6rt]

Migrated from rt.perl.org#128857 (status was 'resolved')

Searchable as RT128857$

[p6rt]

From @zoffixznet

TimToady's comments on the matter​: http://irclog.perlgeek.de/perl6-dev/2016-08-06#i_12976358

I stumbled on this while examining https://rt-archive.perl.org/perl6/Ticket/Display.html?id=127341#ticket-history

It seems this commit had a consequence that .Rat on an Inf or NaN does not actually return an object that can be stored in a Rat​: rakudo/rakudo@498d0a4

The issue is now there's no guarantee that a .Rat can be used as a Rat and thus the programmer has to perform additional checks.

Here are some examples of the issue​:

<Zoffix> m​: say â��.Rat ~~ Rat
<camelia> rakudo-moar 589061​: OUTPUT«Falseâ�¤Â»
<Zoffix> m​: Duration.new​: NaN
<camelia> rakudo-moar 589061​: OUTPUT«Type check failed in assignment to $!tai; expected Rat but got Rational[Num,Int] (?)â�¤ in block <unit> at <tmp> line 1â�¤â�¤Â»
<Zoffix> m​: Duration.new​: â��
<camelia> rakudo-moar 589061​: OUTPUT«Type check failed in assignment to $!tai; expected Rat but got Rational[Num,Int] (?)â�¤ in block <unit> at <tmp> line 1â�¤â�¤Â»
<Zoffix> m​: class { has Rat $.secret-ingredient; method new ($v) { self.bless​: secret-ingredient => $v.Rat } }.new​: â��
<camelia> rakudo-moar 589061​: OUTPUT«Type check failed in assignment to $!secret-ingredient; expected Rat but got Rational[Num,Int] (?)â�¤ in method new at <tmp> line 1â�¤ in block <unit> at <tmp> line 1â�¤â�¤Â»
<Zoffix> m​: my Rat $x = â��.Rat
<camelia> rakudo-moar 589061​: OUTPUT«Type check failed in assignment to $x; expected Rat but got Rational[Num,Int] (?)â�¤ in block <unit> at <tmp> line 1â�¤â�¤Â»

--
Cheers,
ZZ | https://twitter.com/zoffix

[p6rt]

From @zoffixznet

On Fri, 05 Aug 2016 20​:18​:01 -0700, cpan@​zoffix.com wrote​:

TimToady's comments on the matter​: http://irclog.perlgeek.de/perl6-
dev/2016-08-06#i_12976358

I stumbled on this while examining
https://rt-archive.perl.org/perl6/Ticket/Display.html?id=127341#ticket-history

It seems this commit had a consequence that .Rat on an Inf or NaN does
not actually return an object that can be stored in a Rat​:
rakudo/rakudo@498d0a4

The issue is now there's no guarantee that a .Rat can be used as a Rat
and thus the programmer has to perform additional checks.

Here are some examples of the issue​:

<Zoffix> m​: say â��.Rat ~~ Rat
<camelia> rakudo-moar 589061​: OUTPUT«Falseâ�¤Â»
<Zoffix> m​: Duration.new​: NaN
<camelia> rakudo-moar 589061​: OUTPUT«Type check failed in assignment
to $!tai; expected Rat but got Rational[Num,Int] (?)� in block <unit>
at <tmp> line 1��»
<Zoffix> m​: Duration.new​: â��
<camelia> rakudo-moar 589061​: OUTPUT«Type check failed in assignment
to $!tai; expected Rat but got Rational[Num,Int] (?)� in block <unit>
at <tmp> line 1��»
<Zoffix> m​: class { has Rat $.secret-ingredient; method new ($v) {
self.bless​: secret-ingredient => $v.Rat } }.new​: â��
<camelia> rakudo-moar 589061​: OUTPUT«Type check failed in assignment
to $!secret-ingredient; expected Rat but got Rational[Num,Int] (?)�
in method new at <tmp> line 1� in block <unit> at <tmp> line 1��»
<Zoffix> m​: my Rat $x = â��.Rat
<camelia> rakudo-moar 589061​: OUTPUT«Type check failed in assignment
to $x; expected Rat but got Rational[Num,Int] (?)� in block <unit> at
<tmp> line 1��»

Thank you for the report. This is now fixed.

Fix​: rakudo/rakudo@042cb7413f87277
Test​: Raku/roast@c3086244fd0c6feea

[p6rt]

@zoffixznet - Status changed from 'new' to 'resolved'