-
Notifications
You must be signed in to change notification settings - Fork 1
Regex Unicode properties check string values before checking bool properties #5966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
From @samcvSee test in properties-general.t The test used to pass before, but only because 'space' resolved to Unicode Since https://github.com/MoarVM/MoarVM/commit/ #?rakudo.moar TODO "Possible bug in NQP where <:space> does not match, |
From @samcvsay ' ' ~~ /<:space>/; #> Nil Should return spaces instead. Checking this works fine though: |
From @samcvAlso see this bisectable results: You can see how with the new commit, 'space' and 'White_Space' now resolve to the same property. Before 'space' resolved to the LF property, and magically worked. When this was fixed and 'space' == 'White_Space', it broke. This bug will be considered close when: use nqp; say nqp::unipropcode('space') == nqp::unipropcode('White_Space') #> True |
From @dogbert17On Wed, 04 Jan 2017 21:27:05 -0800, samantham@posteo.net wrote:
Fixed with commit rakudo/rakudo@49dce16 |
The RT System itself - Status changed from 'new' to 'open' |
From @samcvThis should be fixed. Though the original bug could be true, it is not visible anymore given the changes where I made sure all property values were distinct for each property name and could not be misaligned in the Unicode database. Could reopen in the future if there is an issue, but see no reason not to close it. This current bug is probably not directly related, but I will link it now since it's the closest I have right now to this bug: MoarVM/MoarVM#818 I haven't fully evaluated the linked bug, but if it turns out to be valid could be useful to have it linked to this one. |
@samcv - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#130483 (status was 'resolved')
Searchable as RT130483$
The text was updated successfully, but these errors were encountered: