Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error message points to CORE.setting, previously it did not (my $x = fail) #5982

Closed
p6rt opened this issue Jan 5, 2017 · 7 comments
Closed

error message points to CORE.setting, previously it did not (my $x = fail) #5982

p6rt opened this issue Jan 5, 2017 · 7 comments

Comments

@p6rt
Copy link

@p6rt p6rt commented Jan 5, 2017

Migrated from rt.perl.org#130509 (status was 'resolved')

Searchable as RT130509$

@p6rt
Copy link
Author

@p6rt p6rt commented Jan 5, 2017

From @AlexDaniel

Code​:
my $x = fail

Result (2015.12,2016.05)​:
Failed
  in block <unit> at /tmp/YwY2tDA0RS line 1

Result (2016.06,HEAD)​:
Failed
  in any at /tmp/whateverable/rakudo-moar/996ab6a04025353083bbf03f03192444c30e3872/share/perl6/runtime/CORE.setting.moarvm line 1
  in block <unit> at /tmp/YwY2tDA0RS line 1

It is mostly OK, but the previous error message was slightly better because it did not point to “CORE.setting.moarvm line 1” (which brings no useful information).

Loading

@p6rt
Copy link
Author

@p6rt p6rt commented Jan 5, 2017

From @AlexDaniel

Golfed to one character.

Code​:

On 2017-01-04 19​:04​:11, alex.jakimenko@​gmail.com wrote​:

Code​:
my $x = fail

Result (2015.12,2016.05)​:
Failed
in block <unit> at /tmp/YwY2tDA0RS line 1

Result (2016.06,HEAD)​:
Failed
in any at /tmp/whateverable/rakudo-
moar/996ab6a04025353083bbf03f03192444c30e3872/share/perl6/runtime/CORE.setting.moarvm
line 1
in block <unit> at /tmp/YwY2tDA0RS line 1

It is mostly OK, but the previous error message was slightly better
because it did not point to “CORE.setting.moarvm line 1” (which brings
no useful information).

Loading

@p6rt
Copy link
Author

@p6rt p6rt commented Jan 6, 2017

From @zoffixznet

m​: Backtrace​::Frame.^lookup("is-setting").wrap​: method () { $.file.starts-with("SETTING​::") or $.file.ends-with("CORE.setting.moarvm") }; …
rakudo-moar dd5759​: OUTPUT«Stub code executed␤ in block <unit> at <tmp> line 1␤␤»

prolly need something similar for JVM

Loading

@p6rt
Copy link
Author

@p6rt p6rt commented Mar 1, 2017

Loading

@p6rt
Copy link
Author

@p6rt p6rt commented Mar 18, 2017

From @usev6

This now works on JVM as well (see rakudo commit c3c86dcf51). The test in t/05-messages/01-errors.t passes.

$ ./perl6-j -e 'my $x = fail'
Failed
  in block <unit> at -e line 1

I'm closing this ticket as 'resolved'.

Loading

1 similar comment
@p6rt
Copy link
Author

@p6rt p6rt commented Mar 18, 2017

From @usev6

This now works on JVM as well (see rakudo commit c3c86dcf51). The test in t/05-messages/01-errors.t passes.

$ ./perl6-j -e 'my $x = fail'
Failed
  in block <unit> at -e line 1

I'm closing this ticket as 'resolved'.

Loading

@p6rt p6rt closed this Mar 18, 2017
@p6rt
Copy link
Author

@p6rt p6rt commented Mar 18, 2017

@usev6 - Status changed from 'new' to 'resolved'

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant