Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dd (0 => 1, 0 => -1, 0 => 0).MixHash Does not delete the key #6343

Closed
p6rt opened this issue Jun 12, 2017 · 5 comments
Closed

dd (0 => 1, 0 => -1, 0 => 0).MixHash Does not delete the key #6343

p6rt opened this issue Jun 12, 2017 · 5 comments

Comments

@p6rt
Copy link

@p6rt p6rt commented Jun 12, 2017

Migrated from rt.perl.org#131561 (status was 'resolved')

Searchable as RT131561$

@p6rt
Copy link
Author

@p6rt p6rt commented Jun 12, 2017

From @zoffixznet

Detected by pre-release ecosystem toasting.

Clifford.pm6 module currently fails due List.MixHash coercer
fails to delete the key when the final weight ends up being zero​:

  <Zoffix> c​: 2017.05,HEAD dd (0 => 1, 0 => -1, 0 => 0, ).MixHash
  <committable6> Zoffix, ¦2017.05​: «().MixHash» ¦HEAD(abfb52b)​: «(0=>0).MixHash»

The issue only appears to happen the weights change from non-zero to zero while going through Pairs​:

  <Zoffix> c​: 2017.05,HEAD dd (0 => 0, ).MixHash
  <committable6> Zoffix, ¦2017.05,HEAD(abfb52b)​: «().MixHash»
  <Zoffix> c​: 2017.05,HEAD dd (0 => 0, 0 => 0,).MixHash
  <committable6> Zoffix, ¦2017.05,HEAD(abfb52b)​: «().MixHash»

@p6rt
Copy link
Author

@p6rt p6rt commented Jun 13, 2017

From @lizmat

Thanks for the report! Fixed with rakudo/rakudo@bf95bcb
Tests will be added shortly.

On 13 Jun 2017, at 00​:52, Zoffix Znet (via RT) <perl6-bugs-followup@​perl.org> wrote​:

# New Ticket Created by Zoffix Znet
# Please include the string​: [perl #​131561]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl6/Ticket/Display.html?id=131561 >

Detected by pre-release ecosystem toasting.

Clifford.pm6 module currently fails due List.MixHash coercer
fails to delete the key when the final weight ends up being zero​:

<Zoffix> c​: 2017.05,HEAD dd (0 => 1, 0 => -1, 0 => 0, ).MixHash
<committable6> Zoffix, ¦2017.05​: «().MixHash» ¦HEAD(abfb52b)​: «(0=>0).MixHash»

The issue only appears to happen the weights change from non-zero to zero while going through Pairs​:

<Zoffix> c​: 2017.05,HEAD dd (0 => 0, ).MixHash
<committable6> Zoffix, ¦2017.05,HEAD(abfb52b)​: «().MixHash»
<Zoffix> c​: 2017.05,HEAD dd (0 => 0, 0 => 0,).MixHash
<committable6> Zoffix, ¦2017.05,HEAD(abfb52b)​: «().MixHash»

@p6rt
Copy link
Author

@p6rt p6rt commented Jun 13, 2017

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

@p6rt p6rt commented Jul 5, 2017

From @dogbert17

On Tue, 13 Jun 2017 01​:13​:43 -0700, elizabeth wrote​:

Thanks for the report! Fixed with
rakudo/rakudo@bf95bcb
Tests will be added shortly.

On 13 Jun 2017, at 00​:52, Zoffix Znet (via RT) <perl6-bugs-
followup@​perl.org> wrote​:

# New Ticket Created by Zoffix Znet
# Please include the string​: [perl #​131561]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl6/Ticket/Display.html?id=131561 >

Detected by pre-release ecosystem toasting.

Clifford.pm6 module currently fails due List.MixHash coercer
fails to delete the key when the final weight ends up being zero​:

<Zoffix> c​: 2017.05,HEAD dd (0 => 1, 0 => -1, 0 => 0, ).MixHash
<committable6> Zoffix, ¦2017.05​: «().MixHash» ¦HEAD(abfb52b)​:
«(0=>0).MixHash»

The issue only appears to happen the weights change from non-zero to
zero while going through Pairs​:

<Zoffix> c​: 2017.05,HEAD dd (0 => 0, ).MixHash
<committable6> Zoffix, ¦2017.05,HEAD(abfb52b)​: «().MixHash»
<Zoffix> c​: 2017.05,HEAD dd (0 => 0, 0 => 0,).MixHash
<committable6> Zoffix, ¦2017.05,HEAD(abfb52b)​: «().MixHash»

Tests have been added, resolving issue

@p6rt
Copy link
Author

@p6rt p6rt commented Jul 5, 2017

@dogbert17 - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.