Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect circularity detection with infix:<+> #6344

Open
p6rt opened this issue Jun 14, 2017 · 2 comments
Open

Incorrect circularity detection with infix:<+> #6344

p6rt opened this issue Jun 14, 2017 · 2 comments
Labels
Bug

Comments

@p6rt
Copy link

@p6rt p6rt commented Jun 14, 2017

Migrated from rt.perl.org#131574 (status was 'new')

Searchable as RT131574$

@p6rt

This comment has been minimized.

Copy link
Author

@p6rt p6rt commented Jun 14, 2017

From @zoffixznet

The circularity detection[^1] code, seems to incorrectly detect this case as circularity​:

16​:28 eveo m​: multi infix​:<+>(Real, Pair $ where {.value === True}) { 42 }; say 1 + :a;
16​:28 camelia rakudo-moar 14d757​: OUTPUT​: «===SORRY!===␤Circularity detected in multi sub types for &infix​:<+>␤»
16​:28 eveo m​: multi infix​:<+>(Real $ where {True}, Pair $ where {.value === True}) { 42 }; say 1 + :a;
16​:28 camelia rakudo-moar 14d757​: OUTPUT​: «===SORRY!===␤Circularity detected in multi sub types for &infix​:<+>␤»

16​:28 eveo m​: multi infix​:<+>(Int, Pair $ where {.value === True}) { 42 }; say 1 + :a;
16​:28 camelia rakudo-moar 14d757​: OUTPUT​: «42␤»

[1] https://github.com/rakudo/rakudo/blob/14d757131159b536d64447f567bc9a8324a271ca/src/Perl6/Metamodel/BOOTSTRAP.nqp#L2157

@p6rt

This comment has been minimized.

Copy link
Author

@p6rt p6rt commented Sep 15, 2017

From @zoffixznet

Some extra comments on this issue​: https://irclog.perlgeek.de/perl6/2017-09-15#i_15169171

15​:15 jnthn Did anyone actually take all the candidates and manually draw out the DAG? :)
15​:17 I can't imagine the cycle detection is a false positive.
15​:17 It is interesting that it ends up with a cycle though

@p6rt p6rt added the Bug label Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.