Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quanthashes should be parameterizable #6689

Closed
p6rt opened this issue Jan 10, 2019 · 7 comments
Closed

Quanthashes should be parameterizable #6689

p6rt opened this issue Jan 10, 2019 · 7 comments

Comments

@p6rt
Copy link

@p6rt p6rt commented Jan 10, 2019

Migrated from rt.perl.org#133762 (status was 'open')

Searchable as RT133762$

@p6rt
Copy link
Author

@p6rt p6rt commented Jan 10, 2019

From @daxim

� rpm -qi rakudo | rg Version
Version : 2018.12

subset Foo of Str where .chars > 0;
my SetHash of Foo %f;
%f.elems.say;

  SetHash cannot be parameterized

subset Foo of Str where .chars > 0;
subset Foo-SetHash of SetHash where $_ ~~ Foo;
my Foo-SetHash $f;
$f.elems.say;

  Invocant of method 'elems' must be an object instance of type 'Setty', not a type object of type 'Foo-SetHash'. Did you forget a '.new'?

subset Foo of Str where .chars > 0;
subset Foo-SetHash of SetHash where $_ ~~ Foo;
my $f = Foo-SetHash.new;
$f.elems.say;

  You cannot create an instance of this type (Foo-SetHash)

Loading

@p6rt
Copy link
Author

@p6rt p6rt commented Jan 13, 2019

From @lizmat

Fixed for Set/SetHash with rakudo/rakudo@4bb5c33

On 10 Jan 2019, at 18​:22, Lars Dɪá´�á´�á´�á´�á´¡ 迪æ��æ�¯ (via RT) <perl6-bugs-followup@​perl.org> wrote​:

# New Ticket Created by Lars Dɪ����ᴡ 迪��
# Please include the string​: [perl #​133762]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl6/Ticket/Display.html?id=133762 >

� rpm -qi rakudo | rg Version
Version : 2018.12

subset Foo of Str where .chars > 0;
my SetHash of Foo %f;
%f.elems.say;

SetHash cannot be parameterized

subset Foo of Str where .chars > 0;
subset Foo-SetHash of SetHash where $_ ~~ Foo;
my Foo-SetHash $f;
$f.elems.say;

Invocant of method 'elems' must be an object instance of type 'Setty', not a type object of type 'Foo-SetHash'. Did you forget a '.new'?

subset Foo of Str where .chars > 0;
subset Foo-SetHash of SetHash where $_ ~~ Foo;
my $f = Foo-SetHash.new;
$f.elems.say;

You cannot create an instance of this type (Foo-SetHash)

Loading

@p6rt
Copy link
Author

@p6rt p6rt commented Jan 13, 2019

The RT System itself - Status changed from 'new' to 'open'

Loading

@p6rt
Copy link
Author

@p6rt p6rt commented Jan 14, 2019

From @lizmat

Fixed for Bag/BagHash with rakudo/rakudo@fe38bdb

Fixed for Mix/MixHash with rakudo/rakudo@bcc8054

On 13 Jan 2019, at 22​:03, Elizabeth Mattijsen via RT <perl6-bugs-followup@​perl.org> wrote​:

Fixed for Set/SetHash with rakudo/rakudo@4bb5c33

On 10 Jan 2019, at 18​:22, Lars Dɪá´�á´�á´�á´�á´¡ 迪æ��æ�¯ (via RT) <perl6-bugs-followup@​perl.org> wrote​:

# New Ticket Created by Lars Dɪ����ᴡ 迪��
# Please include the string​: [perl #​133762]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl6/Ticket/Display.html?id=133762 >

� rpm -qi rakudo | rg Version
Version : 2018.12

subset Foo of Str where .chars > 0;
my SetHash of Foo %f;
%f.elems.say;

SetHash cannot be parameterized

subset Foo of Str where .chars > 0;
subset Foo-SetHash of SetHash where $_ ~~ Foo;
my Foo-SetHash $f;
$f.elems.say;

Invocant of method 'elems' must be an object instance of type 'Setty', not a type object of type 'Foo-SetHash'. Did you forget a '.new'?

subset Foo of Str where .chars > 0;
subset Foo-SetHash of SetHash where $_ ~~ Foo;
my $f = Foo-SetHash.new;
$f.elems.say;

You cannot create an instance of this type (Foo-SetHash)

Loading

@p6rt p6rt added the testneeded label Jan 5, 2020
@JJ
Copy link

@JJ JJ commented May 7, 2020

I would say this is fixed? All possible QuantHashes have been fixed.

Loading

@lizmat
Copy link
Contributor

@lizmat lizmat commented May 7, 2020

Indeed. But I think it may still need tests?

Loading

lizmat added a commit to Raku/roast that referenced this issue May 7, 2020
@lizmat
Copy link
Contributor

@lizmat lizmat commented May 7, 2020

Tests added with Raku/roast@fa99dd6

Loading

@lizmat lizmat closed this May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants