Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement renaming of named parameters in Rakudo #699

Closed
p6rt opened this issue Feb 14, 2009 · 8 comments
Closed

Implement renaming of named parameters in Rakudo #699

p6rt opened this issue Feb 14, 2009 · 8 comments
Labels

Comments

@p6rt
Copy link

p6rt commented Feb 14, 2009

Migrated from rt.perl.org#63230 (status was 'resolved')

Searchable as RT63230$

@p6rt
Copy link
Author

p6rt commented Feb 14, 2009

From @masak

$ perl6 -e 'sub formalize($text, :case($case), :justify($justify)) {...}'
Unable to parse multisig; couldn't find final ')' at line 1, near "​:case($cas"
[...]

Example straight out of S06​:721.

@p6rt
Copy link
Author

p6rt commented Mar 15, 2009

From @masak

<masak> rakudo​: sub formalize($text, :case($case), :justify($justify)) {...}
<p6eval> rakudo 5b1ff9​: OUTPUT«Unable to parse multisig; couldn't find
final ')' at line 1, near "​:case($cas" [...]
<masak> wtf? this a known regression?
<masak> that one is straight from S06.
<masak> I'm pretty sure it used to work.
<ruoso> rakudo​: sub formalize($text, :$case, :$justify) {...}
<p6eval> rakudo 5b1ff9​: RESULT«{ ... }»
<masak> ok, so the sugared form still works.
<ruoso> masak, your signature was just wrong ;)
<masak> ruoso​: nope. see S06.
<ruoso> std​: sub formalize($text, :case($case), :justify($justify)) {...}
<p6eval> std 25840​: OUTPUT«ok 00​:02 35m␤»
<ruoso> interesting
* masak submits rakudobug

@p6rt
Copy link
Author

p6rt commented Mar 15, 2009

From @masak

<jnthn> masak​: (signature one) It's not a bug. We have a ticket saying
it's to implement in fact.
<jnthn> Well, not a regression anyway.
<masak> jnthn​: it used to work!
<jnthn> masak​: Parse, or work? I've never known it to work... :-|
<masak> perhaps I'm thinking of some other Perl 6 implementation...
<jnthn> Perhaps.
<jnthn> I know we have a ticket to implement it in Rakudo for a while
though.
<jnthn> (Should be an easy patch to write.)
<masak> jnthn​: no, it used to work! we have it in the November source,
code that is currently running on the web on an older version of Rakudo.
<masak> please make it work again.
<jnthn> OK, then clearly it wasn't tested...
* masak adds this to the ticket

@p6rt
Copy link
Author

p6rt commented Mar 15, 2009

@masak - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Mar 15, 2009

From @masak

<masak> jnthn​: um, to be fair, I might have simply been confused about
caller/callee-side on the matter of named params. sorry about that. :/
<masak> I'll see if I find the TODO ticket, and merge them.
<jnthn> masak​: Ah. That would answer it...
<masak> aye.
* masak adds that too
<masak> heh, and it turns out I was the reporter of the old bug. :P
<masak> same one-liner, even.

@p6rt
Copy link
Author

p6rt commented Mar 20, 2009

From @jnthn

On Sat Feb 14 03​:58​:06 2009, masak wrote​:

$ perl6 -e 'sub formalize($text, :case($case), :justify($justify))
{...}'
Unable to parse multisig; couldn't find final ')' at line 1, near
"​:case($cas"
[...]

Example straight out of S06​:721.

Implemented in git 703b36e plus added tests because I couldn't find any
existing ones for this (but maybe I missed them too).

Thanks,

Jonathan

@p6rt
Copy link
Author

p6rt commented Mar 20, 2009

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Mar 20, 2009

@jnthn - Status changed from 'open' to 'resolved'

@p6rt p6rt closed this as completed Mar 20, 2009
@p6rt p6rt added the Todo label Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant