From 39eef583eff173d8ed2dcc9cf2b3d5afd3f30ee6 Mon Sep 17 00:00:00 2001 From: Stefan Seifert Date: Wed, 9 Sep 2015 22:17:56 +0200 Subject: [PATCH] RT #124640 fixed by merging Enum and Pair --- S06-traits/is-rw.t | 2 -- S32-array/pairs.t | 1 - S32-hash/kv.t | 4 ++-- S32-hash/pairs.t | 1 - 4 files changed, 2 insertions(+), 6 deletions(-) diff --git a/S06-traits/is-rw.t b/S06-traits/is-rw.t index 00c9606bfd..9d7336c05d 100644 --- a/S06-traits/is-rw.t +++ b/S06-traits/is-rw.t @@ -33,13 +33,11 @@ plan 7; my %hash = (a => 23); # First check .value = ... works (as this is a dependency for the next test) try { %hash.pairs[0].value = 42 }; -#?rakudo todo 'RT #124640' is %hash, 42, "pairs are mutable"; for %hash.pairs -> $pair { # Note: No "is rw"! try { $pair.value += 100 }; # Modifies %hash } -#?rakudo todo 'Depends on preceding test working RT #124640' is %hash, 142, "'is rw' not necessary on objects/references"; } diff --git a/S32-array/pairs.t b/S32-array/pairs.t index cc80755b81..a9675ec344 100644 --- a/S32-array/pairs.t +++ b/S32-array/pairs.t @@ -49,7 +49,6 @@ Basic C tests, see S32. $pair.value += 100; } }, 'aliases returned by @array.pairs should be rw (1)'; - #?rakudo todo 'Apparently not rw yet?' is @array[1], 123, 'aliases returned by @array.pairs should be rw (2)'; } diff --git a/S32-hash/kv.t b/S32-hash/kv.t index b1420a8c9e..7012c952e3 100644 --- a/S32-hash/kv.t +++ b/S32-hash/kv.t @@ -120,12 +120,12 @@ for %hash.kv -> $key, $value { } { - my $pair = (a => 42); + my $pair = (a => my $ = 42); #?niecza todo 'aliases should be rw' lives-ok { for $pair.kv -> $key, $value is rw { $value += 100; - } }, 'aliases returned by $pair.kv should be rw (1)'; + } }, 'aliases to items returned by $pair.kv should be rw (1)'; #?niecza todo 'aliases should be rw' is $pair.value, 142, 'aliases returned by $pair.kv should be rw (2)'; diff --git a/S32-hash/pairs.t b/S32-hash/pairs.t index 0d4ab79b6b..eff05c09a8 100644 --- a/S32-hash/pairs.t +++ b/S32-hash/pairs.t @@ -65,7 +65,6 @@ Basic C tests, see S32::Containers. $pair.value += 100; } }, 'aliases returned by %hash.pairs should be rw (1)'; - #?rakudo todo "Rakudo seems to make a copy rather than a reference, RT #124640" is %hash, 102, 'aliases returned by %hash.pairs should be rw (2)'; }