Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Lots of JVM un-skips/un-todos from today's fixes.
  • Loading branch information
jnthn committed Sep 25, 2013
1 parent bf4c89e commit 5f763f9
Show file tree
Hide file tree
Showing 7 changed files with 0 additions and 12 deletions.
1 change: 0 additions & 1 deletion S02-names-vars/perl.t
Expand Up @@ -145,7 +145,6 @@ my @tests = (

# RT #62002 -- validity of default .perl
my $t2_init = eval($t1_init).perl;
#?rakudo.jvm skip "some random values cause the roundtrip to fail"
is $t1_init, $t2_init, '.perl on user-defined type roundtrips okay';
}

Expand Down
6 changes: 0 additions & 6 deletions S02-names/is_default.t
Expand Up @@ -57,18 +57,14 @@ plan 114;
is $b, 768, "typed variable should be initialized";
is $b.VAR.default, 42, 'is the default set correctly for Int $b';

#?rakudo.jvm emit #
my Int $c is default(Nil);
#?rakudo.jvm 5 skip 'Type check failed in assignment to "$c"; expected "Int" but got "Any"'
ok $c.VAR.default === Nil, 'is the default set correctly for Int $c';
lives_ok { $c++ }, 'should be able to increment typed variable';
is $c, 1, "typed variable should be incremented";
lives_ok { $c = Nil }, "should be able to assign Nil to typed variable";
ok $c === Nil, 'is the default value correctly reset for Int $c';

#?rakudo.jvm emit #
my Int $d is default(Nil) = 353;
#?rakudo.jvm 2 skip 'Type check failed in assignment to "$d"; expected "Int" but got "Any"'
is $d, 353, "typed variable should be initialized";
ok $d.VAR.default === Nil, 'is the default set correctly for Int $d';
} #19
Expand Down Expand Up @@ -129,7 +125,6 @@ plan 114;
ok @c.VAR.default === Nil, 'is the default set correctly for Int @c';
lives_ok { @c[0]++ }, 'should be able to increment typed variable';
is @c[0], 1, "typed variable should be incremented";
#?rakudo.jvm 2 todo "nigh"
lives_ok { @c[0] = Nil }, "able to assign Nil to typed variable";
ok @c[0] === Nil, 'is the default value correctly reset for Int @c[0]';

Expand Down Expand Up @@ -194,7 +189,6 @@ plan 114;
ok %c.VAR.default === Nil, 'is the default set correctly for Int %c';
lives_ok { %c<o>++ }, 'should be able to increment typed variable';
is %c<o>, 1, "typed variable should be incremented";
#?rakudo.jvm 2 todo "nigh"
lives_ok { %c<o> = Nil }, "able to assign Nil to typed variable";
ok %c<o> === Nil, 'is the default value correctly reset for Int %c<o>';

Expand Down
1 change: 0 additions & 1 deletion S02-names/pseudo.t
Expand Up @@ -311,7 +311,6 @@ plan 142;
}

# CALLER - assumes MY:: has taken care of most access testing
#?rakudo.jvm skip "Nominal type check failed for parameter 'null'"
{
sub f1($f) { my $x is dynamic = 90; $f() } #OK
sub f2($f) { my $x is dynamic = 91; f1($f) } #OK
Expand Down
1 change: 0 additions & 1 deletion S02-names/symbolic-deref.t
Expand Up @@ -98,7 +98,6 @@ my $outer = 'outside';
$result = $sub();
};

#?rakudo.jvm todo "nigh"
is $result, 42, "symbolic dereferentation works with ::CALLER, too";
}

Expand Down
1 change: 0 additions & 1 deletion S02-types/lists.t
Expand Up @@ -149,7 +149,6 @@ plan 28;
try { eval '<1 2 3>.rt62836' };
#?pugs 2 todo
ok "$!" ~~ /rt62836/, 'error message contains name of sub';
#?rakudo.jvm todo "nigh"
ok "$!" ~~ /Parcel/, 'error message contains name of class';

#?pugs emit #
Expand Down
1 change: 0 additions & 1 deletion S02-types/nil.t
Expand Up @@ -100,7 +100,6 @@ ok !Nil.new.defined, 'Nil.new is not defined';
ok $! === Nil, '$! is by default Nil';
ok $_ === Nil, '$_ is by default Nil';

#?rakudo.jvm 3 skip "Nominal type check failed for parameter 'null'"
ok $/.VAR.default === Nil, '$/ has Nil as default';
ok $!.VAR.default === Nil, '$! has Nil as default';
ok $_.VAR.default === Nil, '$_ has Nil as default';
Expand Down
1 change: 0 additions & 1 deletion S03-binding/scalars.t
Expand Up @@ -42,7 +42,6 @@ eval_dies_ok '0 := 1', 'cannot bind to a literal';
# Binding and $CALLER::
#XXX This can pass bogusly (was doing for Rakudo for a while).
#?niecza skip 'CALLER::'
#?rakudo.jvm skip 'is dynamic'
{
sub bar {
return $CALLER::a eq $CALLER::b;
Expand Down

0 comments on commit 5f763f9

Please sign in to comment.