Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken todo-ed precomp interning test #391

Closed
zoffixznet opened this issue Feb 25, 2018 · 1 comment
Closed

Broken todo-ed precomp interning test #391

zoffixznet opened this issue Feb 25, 2018 · 1 comment

Comments

@zoffixznet
Copy link
Contributor

https://irclog.perlgeek.de/perl6/2018-02-25#i_15857861

pmurias | https://github.com/perl6/roast/blob/master/S10-packages/precompilation.t#L169 - this test is broken as we just don't find the module this way
 (so if the interning works or not is not even tested)

The test loads modules by name but there's no source file and only a $precomp-ext file.

Is such loading mechanism meant to work?
niner added a commit that referenced this issue Mar 2, 2018
@niner
Fix broken todo-ed precomp interning test
ad4aef0 
Don't expect an implementation to load a precompiled file without accompanying
source file. Instead, expect precompilation to be done implicitly like so many
other tests already do. The only reason why this wasn't done at the same time
as for other tests is that this was todo-ed and nobody looked at the failure
close enough to notice the breakage till pmurias++ came along.
Fixes GH #391
@niner
Copy link
Contributor

niner commented Mar 2, 2018

No, rakudo won't find the precomp file this way. The only way to load it would be to require with a path instead of a module name. Better to just assume implicit precompilation like all the other tests do. Fixed with commit ad4aef0

@niner niner closed this as completed Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@niner @zoffixznet