Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multichar line sep on server socket #38

Closed
wants to merge 2 commits into from
Closed

Conversation

simula67
Copy link
Contributor

This test verifies that the sockets can operate on
multichar line seperators for calls to get.

This should already have been verified by test 5.
Somehow that test passes when this one does not.
Test 5 seems to the on the client socket.

jnthn mentioned that MOAR does not like multichar
line sepearators. But the problem seems to persist
for Parrot and JVM backend in a slightly different
manner.

I only tested this patch on Linux.

This test verifies that the sockets can operate on
multichar line seperators for calls to get.

This should already have been verified by test 5.
Somehow that test passes when this one does not.
Test 5 seems to the on the client socket.

jnthn mentioned that MOAR does not like multichar
line sepearators. But the problem seems to persist
for Parrot and JVM backend in a slightly different
manner.

I only tested this patch on Linux.
@simula67
Copy link
Contributor Author

The second commit should fix the test for JVM and Parrot.
I forgot that "say" automatically appends a Line Feed.

This test seems redundant now since MOAR already seems to fail on test 5

Copy link
Contributor

@JJ JJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so old I don't know if it's still worth the while, but maybe if you solve the conflicts we can see if we can use it.

@JJ
Copy link
Contributor

JJ commented May 6, 2020

Conflicts not solved, probably best to close it.

@JJ JJ closed this May 6, 2020
@AlexDaniel
Copy link
Member

Let us know if there's still an issue, preferably by filing a bug report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants