Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bisectable should detect NQP bumps and ask Geth to show relevant commits #114

Closed
AlexDaniel opened this issue Mar 12, 2017 · 3 comments
Closed

Bisectable should detect NQP bumps and ask Geth to show relevant commits #114

AlexDaniel opened this issue Mar 12, 2017 · 3 comments
Labels
bisectable Issues related to Bisectable bot

Comments

@AlexDaniel
Copy link
Member

AlexDaniel commented Mar 12, 2017 •
edited

We can delegate it to Geth like this:

<IOninja> Geth: ver https://github.com/rakudo/rakudo/commit/22f00cd72deaaaafbaeb1ad83187309854e33739
<Geth> IOninja, version bump brought in these changes: https://github.com/perl6/nqp/compare/2017.02-67-g5023309...2017.02-69-g4ceee06d

Or we can do it ourselves.
@AlexDaniel AlexDaniel added the bisectable Issues related to Bisectable bot label Mar 12, 2017
@AlexDaniel AlexDaniel added the blocked ☹ Underlying issue is outside this repo, a ticket was filed label Feb 11, 2018
@AlexDaniel
Copy link
Member Author

Last time I tried Geth was broken and didn't give any meaningful result. Also, nowadays bump commits have proper descriptions.

@AlexDaniel AlexDaniel removed the blocked ☹ Underlying issue is outside this repo, a ticket was filed label Jun 2, 2018
@AlexDaniel
Copy link
Member Author

I think Geth is working correctly now, but maybe we should write some code for it in this repo (shouldn't be too difficult).

@AlexDaniel
Copy link
Member Author

Closing this in favor of #40.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bisectable Issues related to Bisectable bot
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlexDaniel