Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

“did you want benchable6 or committable6?” #128

Open
AlexDaniel opened this issue Apr 15, 2017 · 2 comments
Open

“did you want benchable6 or committable6?” #128

AlexDaniel opened this issue Apr 15, 2017 · 2 comments
Labels
bisectable Issues related to Bisectable bot

Comments

@AlexDaniel
Copy link
Member

When the message starts with HEAD, releases, 2015.12, etc. it is clear that somebody wanted to use committable or benchable, not bisectable.

I think bisectable can detect that and print a useful error message.
@AlexDaniel AlexDaniel added the bisectable Issues related to Bisectable bot label Apr 15, 2017
@AlexDaniel
Copy link
Member Author

Or maybe it should simply ignore the first word

@AlexDaniel AlexDaniel added the good first issue Low-hanging fruit (relatively easy issue, good for drive-by contributions) label May 20, 2017
@AlexDaniel AlexDaniel removed the good first issue Low-hanging fruit (relatively easy issue, good for drive-by contributions) label Jun 2, 2018
@AlexDaniel
Copy link
Member Author

By the way, this syntax is now also supported:

<AlexDaniel> bisect: 2015.12,2016.01 say rand
<bisectable6> AlexDaniel, Using old=2015.12 new=2016.01 in an attempt to DWIM
<bisectable6> AlexDaniel, Bisecting by output (old=2015.12 new=2016.01) because on both starting points the exit code is 0
… … …

But it doesn't understand a single revision because IIRC there are cases when it would be ambiguous.

AlexDaniel added a commit that referenced this issue Jun 16, 2020
@AlexDaniel
Make Bisectable even more awesome
187d36a 
Previously it was assumed that the user knows that there was in fact a
change in behavior before triggering the bot. It made sense because
there was a separate bot (Committable) that allowed to get that
information. However, this expectation doesn't match reality and how
actual users are using the bot.

This commit combines functionality of Committable and Bisectable into
one, meaning that by default you can just give a piece of code to
Bisectable and it will first get the output on all releases and only
then bisect all of the changes if possible/needed. Sometimes no
interface is better than a good interface, and a single “do something”
command is better than requiring to run multiple commands and
understanding what all of them do and why.

Previous behavior is preserved as long as you give any arguments (like
old= or new=).

The output is currently somewhat noisy but we will see how it goes. If
it turns out to be more annoying than useful then something will be
done about it.

Somewhat related: #128 #257
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bisectable Issues related to Bisectable bot
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlexDaniel