Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You could hang committable and benchable for a really long time by sleeping for the max timeout for the max number of commits #13

Open
MasterDuke17 opened this issue Jul 27, 2016 · 6 comments
Labels
all bots Issues affecting all (or most) of the bots testneeded Issue is generally resolved but tests were not written yet

Comments

@MasterDuke17
Copy link
Collaborator

It would be good to have a timer around the loop that runs the code for each commit so we can bail out if the total time is taking too long, in addition to the alarm-based timeout for each individual run.

@zoffixznet
Copy link
Contributor

Performing the work in a non-blocking way would also help.

It's just a start keyword away in new and improved IRC::Client 😸

    use IRC::Client;
    .run with IRC::Client.new:
        :nick<MahBot>
        :host<irc.freenode.net>
        :channels<#perl6>
        :debug
        :plugins(class Bisectable { multi method irc-addressed ($e) { start do-bisection $e.text } })

@AlexDaniel
Copy link
Member

AlexDaniel commented Jul 27, 2016

@zoffixznet we know :)

We are going to rewrite it in 6lang as soon as possible. Thank you for IRC::Client.

@MasterDuke17
Copy link
Collaborator Author

And it looks like there's lots of work going on with IRC::Client, nice.

@MasterDuke17
Copy link
Collaborator Author

Fixed for committable and benchable in b19c8e2.

@MasterDuke17
Copy link
Collaborator Author

Fixed for committable6 and benchable6, bisectable(6) already have this capability.

@AlexDaniel AlexDaniel added the all bots Issues affecting all (or most) of the bots label Sep 21, 2016
@AlexDaniel AlexDaniel added the testneeded Issue is generally resolved but tests were not written yet label Jan 6, 2017
@AlexDaniel AlexDaniel reopened this Mar 12, 2017
@AlexDaniel
Copy link
Member

AlexDaniel commented Jun 2, 2018

Here's the list of all bots, mark anything that has a test already or if such tests don't apply for that bot:

  • Bisectable
  • Committable
  • Benchable
  • Evalable
  • Statisfiable
  • Unicodable
  • Bloatable
  • Quotable
  • Greppable
  • Coverable
  • Releasable
  • Nativecallable
  • Squashable
  • Reportable
  • Notable
  • Shareable
  • Undersightable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
all bots Issues affecting all (or most) of the bots testneeded Issue is generally resolved but tests were not written yet
Projects
None yet
Development

No branches or pull requests

3 participants