Make it understand / ‘.say’ $ / too #130
Labels
evalable
Issues related to Evalable bot
testneeded
Issue is generally resolved but tests were not written yet
Comments
|
That said, sometimes it triggers when people don't want to: |
|
I noticed that every time it was mistriggered, the snippet produced non-zero exit code. Maybe if we add a check for that it will become significantly better. See also: #53 |
|
Also maybe reply on |
AlexDaniel
added a commit
that referenced
this issue
Jan 31, 2018
This should trigger more and less at the same time. We will no longer see annoying evals that result in compile time error, but we might see it being triggered on things that actually work (even if surprisingly). Somewhat similar to Braitenberg vehicles, achieves intelligent behavior using even simpler rules. Can now detect code in any message, not just starting with “say”. Contrary to the logical approach of detecting code and then running it, it runs every message first and then only sends a response if the output is nice (0 exit code, no warnings, etc.). Rhesolves #53, #130
AlexDaniel
added
the
testneeded
AlexDaniel
added a commit
that referenced
this issue
Feb 6, 2018
Motivated by this situation: https://irclog.perlgeek.de/perl6/2018-02-05#i_15780531 Related issues: #53, #130.
|
This was properly resolved together with #53, and I think there are enough tests for this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Nowadays evalable allows you to omit
m::However, it only works if you start your message with
say. A lot of the times people end their messages with.say, like here.As always, we should find the amount of times it could've mistakenly triggered in the past if the feature was implemented (use quotable for that).
The text was updated successfully, but these errors were encountered: