Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greppable and short output #151

Open
AlexDaniel opened this issue May 24, 2017 · 3 comments
Open

Greppable and short output #151

AlexDaniel opened this issue May 24, 2017 · 3 comments
Labels
greppable Issues related to Greppable bot testneeded Issue is generally resolved but tests were not written yet

Comments

@AlexDaniel
Copy link
Member

<AlexDaniel> grep: method get-message\(\$password\)\{
<greppable6> AlexDaniel, LLFourn/p6-AttrX-InitArg/README.md:13:    method get-message($password){␤LLFourn/p6-AttrX-InitArg/t/example0.t:11:    method get-message($password){

I think this could've been printed as two separated messages.

@AlexDaniel AlexDaniel added the greppable Issues related to Greppable bot label May 24, 2017
@AlexDaniel
Copy link
Member Author

Right now it behaves a little bit differently:

<AlexDaniel> grep: method get-message\(\$password\)\{
<greppable6> AlexDaniel, https://gist.github.com/5dc24f4e3f934b8acde917e583c983a9

Should we actually attempt to print anything in the chat if there are ≤3 results?

@AlexDaniel
Copy link
Member Author

The output is much better now:

<greppable6> AlexDaniel, 2 lines, 1 modules: https://gist.github.com/7020e771a297657ace4bf5e75b3b38d9

IMO that's good enough.

@AlexDaniel
Copy link
Member Author

Looks correct, but it needs tests.

@AlexDaniel AlexDaniel added the testneeded Issue is generally resolved but tests were not written yet label Jun 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
greppable Issues related to Greppable bot testneeded Issue is generally resolved but tests were not written yet
Projects
None yet
Development

No branches or pull requests

1 participant