Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests to ensure that we can actually upload github gists #223

Open
AlexDaniel opened this issue Sep 2, 2017 · 3 comments
Open

Tests to ensure that we can actually upload github gists #223

AlexDaniel opened this issue Sep 2, 2017 · 3 comments
Labels
committable Issues related to Committable bot testneeded Issue is generally resolved but tests were not written yet

Comments

@AlexDaniel
Copy link
Member

<AlexDaniel> c: all <a b c d>».say
<committable6> AlexDaniel, Sorry kid, that's not my department.

<AlexDaniel> c: HEAD react whenever signal(SIGINT).merge(signal(SIGHUP)) { say ‘hey!’; exit 0 }
<committable6> AlexDaniel, Sorry kid, that's not my department.

@AlexDaniel AlexDaniel added the committable Issues related to Committable bot label Sep 2, 2017
@AlexDaniel
Copy link
Member Author

Can't reproduce on HEAD.

@AlexDaniel AlexDaniel added the testneeded Issue is generally resolved but tests were not written yet label Mar 9, 2018
@AlexDaniel
Copy link
Member Author

I guess we can just add these as tests.

@AlexDaniel
Copy link
Member Author

Honestly I see nothing special about these queries, except that both of them upload gists. Maybe that's exactly what was failing. Now that I think about it, we have no tests for actually uploading stuff to github, and that somewhat makes sense. But does it mean that some issues can go unnoticed? Hmm…

@AlexDaniel AlexDaniel changed the title Two department issues Tests to ensure that we can actually upload github gists Jun 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
committable Issues related to Committable bot testneeded Issue is generally resolved but tests were not written yet
Projects
None yet
Development

No branches or pull requests

1 participant