Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The watchdog should work based on ping events #276

Open
AlexDaniel opened this issue Jan 26, 2018 · 0 comments
Open

The watchdog should work based on ping events #276

AlexDaniel opened this issue Jan 26, 2018 · 0 comments
Labels
blocked ☹ Underlying issue is outside this repo, a ticket was filed whateverable Issues affecting the bot framework (and therefore all of the bots)

Comments

@AlexDaniel
Copy link
Member

Basically, the watchdog ensures that bots are not stuck in some weird state. Currently it works like this:
https://github.com/perl6/whateverable/blob/7f79d1d1d4cf4d791ad1fca0c0db0e41b6fc36fb/lib/Whateverable.pm6#L181-L185

In other words, someone must send a message to the channel every so often, otherwise bots commit mass suicide thinking that they're disconnected. One of the motivations for this feature is this bug: lizmat/IRC-Client#40

Currently there's no way to handle pings in IRC::Client, so there's no better way to do that. I filed a feature request here:
lizmat/IRC-Client#50

That said, the issue is that sometimes nobody says anything for relatively long periods of time (more than 30 minutes). This forces us to have high timeouts, which is again less than awesome.

@AlexDaniel AlexDaniel added the whateverable Issues affecting the bot framework (and therefore all of the bots) label Jan 26, 2018
AlexDaniel added a commit that referenced this issue Jan 26, 2018
The way it works is a workaround, see issue #276 for more info.
@AlexDaniel AlexDaniel added the blocked ☹ Underlying issue is outside this repo, a ticket was filed label Jun 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked ☹ Underlying issue is outside this repo, a ticket was filed whateverable Issues affecting the bot framework (and therefore all of the bots)
Projects
None yet
Development

No branches or pull requests

1 participant