Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code in Unicodable #78

Open
AlexDaniel opened this issue Dec 12, 2016 · 3 comments
Open

Improve code in Unicodable #78

AlexDaniel opened this issue Dec 12, 2016 · 3 comments
Labels
help wanted unicodable Issues related to Unicodable bot

Comments

@AlexDaniel
Copy link
Member

The code is not good at all.
@AlexDaniel AlexDaniel added the unicodable Issues related to Unicodable bot label Dec 12, 2016
@AlexDaniel
Copy link
Member Author

Depends on #68

@AlexDaniel AlexDaniel added the testneeded Issue is generally resolved but tests were not written yet label Jan 6, 2017
@AlexDaniel AlexDaniel removed the testneeded Issue is generally resolved but tests were not written yet label Mar 12, 2017
@AlexDaniel AlexDaniel changed the title Clean up Unicodable Improve code in Unicodable Apr 7, 2017
AlexDaniel added a commit that referenced this issue Jul 31, 2017
@AlexDaniel
*Lots* of refactoring and other tweakery
a324dfd 
Resolves: #77, #78, #185 and possibly many others

This commit includes all kinds of bug fixes, code improvements, and
other non-important code mangling.

Mainly, things were accomodated to previous commits (grumble instead
of doing a lot of checks, no more need to “but Reply”, etc.).

I tried to remove as much code as possible, but I don't think I did
very well. Things are already written very tightly and there are no
huge opportunities to reduce the code size without making it less
readable. That said, some copy-pasted parts were removed.

Huge part of Committable was rewritten completely.

I think this gets rid of a huge part of technical debt of this
project, but there are still things to improve.

I could've split this commit into thirty separate commits, but I'm
already way over the point of diminishing returns…
@AlexDaniel
Copy link
Member Author

Is it good enough now?

@AlexDaniel
Copy link
Member Author

Actually, it would be nice to go over the whole code base and do a lot of refactoring. When this project started there was only one bot (bisectable), and a bit later another one (committable). What was good back then is not good anymore because the code base was constantly growing, so just one library file (Whateverable.pm6) no longer cuts it. I did many refactoring commits over the years, but it seems like the code base is increasing a bit faster than I can refactor it. Any help will be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted unicodable Issues related to Unicodable bot
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlexDaniel