Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Something wrong with bisectable (let's chdir less) #90

Closed
AlexDaniel opened this issue Jan 14, 2017 · 2 comments
Closed

Something wrong with bisectable (let's chdir less) #90

AlexDaniel opened this issue Jan 14, 2017 · 2 comments
Labels
bisectable Issues related to Bisectable bot testneeded Issue is generally resolved but tests were not written yet

Comments

@AlexDaniel
Copy link
Member

See https://irclog.perlgeek.de/perl6-dev/2017-01-14#i_13921221

It thinks that the exit code is 1 when it's not.

@AlexDaniel AlexDaniel added bisectable Issues related to Bisectable bot testneeded Issue is generally resolved but tests were not written yet labels Jan 14, 2017
@AlexDaniel AlexDaniel removed the testneeded Issue is generally resolved but tests were not written yet label Mar 12, 2017
@AlexDaniel
Copy link
Member Author

Interesting! The reason it happens is because the code snippet is using a file in foo directory. But bisectable chdirs into rakudo-moar in order to do its stuff. Ideally we don't want to use chdir at all, but in reality not all git commands allow to specify the working directory. For some reason I decided to use chdir instead of passing :$cwd to run. Obviously, this was a mistake.

@AlexDaniel AlexDaniel changed the title Something wrong with bisectable Something wrong with bisectable (let's chdir less) Jul 22, 2017
AlexDaniel added a commit that referenced this issue Jul 22, 2017
… stop changing your current directory.

Resolves issue #90.

I did not unchdirify build.p6 because I am so scared to break it.
@AlexDaniel
Copy link
Member Author

AlexDaniel commented Jul 22, 2017

<AlexDaniel> bisectable6test: for dir(‘foo’) { .slurp.say }
<bisectable6> AlexDaniel, Bisecting by exit code (old=2015.12 new=752a326). Old exit code: 1
<bisectable6> AlexDaniel, bisect log: https://gist.github.com/068a06a1469961a3afaf7e8f8e65a036
<bisectable6> AlexDaniel, (2017-01-02) rakudo/rakudo@7c8b705
<AlexDaniel> \o/

@AlexDaniel AlexDaniel added the testneeded Issue is generally resolved but tests were not written yet label Jul 22, 2017
JJ pushed a commit to JJ/whateverable that referenced this issue Jun 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bisectable Issues related to Bisectable bot testneeded Issue is generally resolved but tests were not written yet
Projects
None yet
Development

No branches or pull requests

1 participant