Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional “What?” command that will explain the results of the last bisect #96

Closed
AlexDaniel opened this issue Jan 27, 2017 · 3 comments
Labels
bisectable Issues related to Bisectable bot

Comments

@AlexDaniel
Copy link
Member

No description provided.

@AlexDaniel AlexDaniel added the bisectable Issues related to Bisectable bot label Jan 27, 2017
@AlexDaniel
Copy link
Member Author

What?

Bisect log is very verbose nowadays, see this example.

So what else has to be explained?

If you are reading this comment, can you tell me if you clearly understand what happens in bisectable under the hood? And if this bisect log is of any help to understand it? And if not, what can be clarified?

@AlexDaniel
Copy link
Member Author

Looking at it again, I don't think anything needs to be done. Can somebody confirm?

@AlexDaniel
Copy link
Member Author

OK I'll confirm myself, it's good enough. There's still a common mistake of throwing random snippets into bisectable in a hope that it'll find something (instead of checking the output using committable and then bisecting narrowly for some particular change), but I don't know if there's anything we can do about it. What could help, however, is if bisectable by default did an extra run on result and result^, but I'm not sure how to implement that without making the output too verbose (it is already at least three lines). I'll keep all that in mind, but meanwhile ‘What?’ command is rejected (although maybe it would be nice if all bots had a ‘What?’ command that would explain the last result).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bisectable Issues related to Bisectable bot
Projects
None yet
Development

No branches or pull requests

1 participant