New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add czech translation #138

Merged
merged 3 commits into from Dec 12, 2017

Conversation

3 participants
@Mrkvozrout
Contributor

Mrkvozrout commented Nov 24, 2017

Added czech translation (locale cs_CZ)

Added czech translation
Added czech translation (locale cs_CZ)
@Mrkvozrout

This comment has been minimized.

Contributor

Mrkvozrout commented Nov 24, 2017

Hi I created czech translation which I want to contribute. It is without dacritics so only basic characters are used (I hope diacritics can be added later). I made a lot of effort to make it as short and as descriptive as possible.

I compared with english texts on the real thing and found out some additional constraints to those in ending line comments:

  • SettingsCalibrationWarning - when this warning is rolling on the screen, the first char immediatelly follows the last char, so I added an extra space
  • WarningAdvancedString - is this the text showed on detailed cooling screen? If so there are only 16 chars shown with no rolling so even in your english translation the last ! is missing
@Mrkvozrout

This comment has been minimized.

Contributor

Mrkvozrout commented Nov 24, 2017

Forgot to check the sleeping texts, will do tomorrow :)

@jonnieZG

This comment has been minimized.

Contributor

jonnieZG commented Nov 24, 2017

I have just added a fix to issue #132, with addition to the font, containing letters from range U+0100 to U+017F. When it gets applied, you can use all your diacritics.

@Mrkvozrout

This comment has been minimized.

Contributor

Mrkvozrout commented Nov 25, 2017

@jonnieZG great work, I will prepare the proper check version then

Mrkvozrout added some commits Nov 25, 2017

Make simple sleep screen more readable
Add gap between "zzz" and temperature for better readability.
Adjusted czech translation
Modified texts after testing on real device to fix char issues and increase readability
@Mrkvozrout

This comment has been minimized.

Contributor

Mrkvozrout commented Nov 25, 2017

I managed to build the firmware with my translation and flash it to my TS100. Tested it and did small adjustments.

@jonnieZG

This comment has been minimized.

Contributor

jonnieZG commented Nov 25, 2017

@Mrkvozrout Jan, did you try with the new Latin-1 font and the diacritics?

@Mrkvozrout

This comment has been minimized.

Contributor

Mrkvozrout commented Nov 25, 2017

@jonnieZG Not yet, I just polished ( :D ) the texts as I managed to upload it to real device. I will definitelly look at your changes and try the diacritics later.

Any special steps to take, or is it just copy-paste and it works?

@jonnieZG

This comment has been minimized.

Contributor

jonnieZG commented Nov 25, 2017

It should be just copy/paste on the two changed files. I haven't installed the compiler yet, so I couldn't test it. According to my experience, it should work, but I must be honest and point out that I didn't get to test it. I am just not sure about the size of the compiled code, because the change adds extra 768 bytes on account of the extra characters.

@Mrkvozrout

This comment has been minimized.

Contributor

Mrkvozrout commented Nov 25, 2017

@Ralim What is the maximum memory limit for the complete firmware? I can see the BIN file has 39kB and I found a comment in LinkerScript.ld that ROM is 48K minus 2 pages (settings and logo) so currently there is something over 6K of free memory left?

@Ralim

This comment has been minimized.

Owner

Ralim commented Nov 26, 2017

Yep.
You're correct in your deductions :)
Which is why I'm not optimising font tables etc just yet :)

I'll be merging this soon when Im on my dev machine.

@Ralim Ralim merged commit 0f4ceb1 into Ralim:master Dec 12, 2017

@Mrkvozrout Mrkvozrout deleted the Mrkvozrout:translation-czech-cs-cz branch Dec 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment