Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for maxFontSizeMultiplier Text prop #2

Open
jacquesdev opened this issue Oct 5, 2023 · 3 comments
Open

Add support for maxFontSizeMultiplier Text prop #2

jacquesdev opened this issue Oct 5, 2023 · 3 comments
Assignees

Comments

@jacquesdev
Copy link

Would it be possible to support this prop https://reactnative.dev/docs/text#maxfontsizemultiplier? Right now if I resize my app all the elements that support it stay the same, but unfortunately this component does not (yet).

@RamProg
Copy link
Owner

RamProg commented Oct 6, 2023

I just published version 1.0.1 which should allow you to pass any text prop to the component, let me know how it goes.

@RamProg RamProg self-assigned this Oct 6, 2023
@jacquesdev
Copy link
Author

@RamProg - would you just pass it in as a prop under the main TextLink component, or does it need to go into an existing prop? I passed it in at the top level, but that doesn't seem to work on my side

@RamProg
Copy link
Owner

RamProg commented Oct 6, 2023

yeah, you should be able to pass any text prop inside the < TextLink /> component and it will pass it along to the < ParsedText /> dependency, make sure you updated to 1.0.1. If that doesn't work I'm afraid it won't be an easy fix because Parsed Text hasn't been updated in 3 years, so I don't think they will be adding support for anything new. Feel free to create a PR if you find a solution and I'm happy to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants