Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PeerReady during relocate only post peer reports a ready state, it remains true initially and then moves to false currently #715

Open
ShyamsundarR opened this issue Feb 13, 2023 · 0 comments
Assignees

Comments

@ShyamsundarR
Copy link
Member

The DRPC reconciler unconditionally moves the observed generation of PeerReady to the current generation, which causes it to report PeerReady as true from the older generation:

drpc.Status.LastUpdateTime = metav1.Now()
for i, condition := range drpc.Status.Conditions {
if condition.ObservedGeneration != drpc.Generation {
drpc.Status.Conditions[i].ObservedGeneration = drpc.Generation
}
}

This is why when Available is still false and the action is in progress, initially the status for PeerReady is moved to true for the current generation.

This needs a fix in ramen drpc reconciler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant