Address missing VR for a PVC during VRG deletion #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There could be cases where a PVC finalizer is present but, during VRG deletion, post deletion of the VR the update to remove the finalizer on the PVC failed. This would on the next reconcile recreate the VR, which stalls deletion processing as the VR cannot add finalizers to the PVC and hence cause the deletion to loop forever and fail. This commit adds checks to ensure VR is missing and if so complete the deletion process for the PVC, and if not perform VR deletion orchestration as usual. Signed-off-by: Shyamsundar Ranganathan <srangana@redhat.com>
BenamarMk
reviewed
Aug 20, 2022
| ) | ||
|
|
||
| if v.instance.Spec.Async.Mode != ramendrv1alpha1.AsyncModeEnabled { | ||
| return !vrMissing, !requeue |
There was a problem hiding this comment.
(nit) I think this block is doing the right thing, but it is confusing. In other words, we return "VR Not Missing" when Sync mode is enabled? it is probably clearer to return false, !requeue
There was a problem hiding this comment.
Understood, instead of using !vrMissing just return false in this instance.
raghavendra-talur
approved these changes
Aug 22, 2022
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There could be cases where a PVC finalizer is present
but, during VRG deletion, post deletion of the VR the update
to remove the finalizer on the PVC failed.
This would on the next reconcile recreate the VR, which stalls
deletion processing as the VR cannot add finalizers to the PVC
and hence cause the deletion to loop forever and fail.
This commit adds checks to ensure VR is missing and if so
complete the deletion process for the PVC, and if not perform
VR deletion orchestration as usual.
Signed-off-by: Shyamsundar Ranganathan srangana@redhat.com