added webhook validation for DRPolicy #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenamarMk
reviewed
Nov 9, 2022
api/v1alpha1/drpolicy_webhook.go
Outdated
| } | ||
|
|
||
| if !reflect.DeepEqual(r.Spec.DRClusters, oldDRPolicy.Spec.DRClusters) { | ||
| return fmt.Errorf("DRClusters value cannot be changed") |
There was a problem hiding this comment.
(nit) should the message be consistent and similar to the other 3? DRClusters cannot be changed
There was a problem hiding this comment.
done. I have rephrased the message
BenamarMk
approved these changes
Nov 9, 2022
rakeshgm
force-pushed
the
webhook-drpolicy
branch
from
ffd74c2
to
805f144
Compare
Signed-off-by: rakeshgm <rakeshgm@redhat.com>
rakeshgm
force-pushed
the
webhook-drpolicy
branch
from
805f144
to
f5843c0
Compare
| @@ -27,6 +27,9 @@ resources: | |||
| kind: DRPolicy | |||
| path: github.com/ramendr/ramen/api/v1alpha1 | |||
| version: v1alpha1 | |||
| webhooks: | |||
| validation: true | |||
| webhookVersion: v1 | |||
There was a problem hiding this comment.
Can we stick to v1alpha1 as in the other CRDs? (applies to DRCluster webhook as well)
ShyamsundarR
approved these changes
Nov 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding webhook validation for DRPolicy. the following objects are immutable.
SchedulingIntervalReplicationClassSelectorVolumeSnapshotClassSelectorDRClustersRelated to BZ: 2005830
Signed-off-by: rakeshgm rakeshgm@redhat.com