Pass-through CA certificates to Velero #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hatfieldbrian <bhatfiel@redhat.com>
tjanssen3
approved these changes
Jun 14, 2023
Comment on lines
-44
to
+39
| s3ProfileName, | ||
| s3StoreProfile.S3CompatibleEndpoint, | ||
| s3StoreProfile.S3Bucket, | ||
| s3StoreProfile.S3Region, | ||
| s3StoreProfile.VeleroNamespaceSecretKeyRef, | ||
| s3StoreProfile, |
There was a problem hiding this comment.
It's not obvious to me why this change is needed in this PR, but it's good refactoring. I believe the requests.go could use similar treatment so it's not required to pass in seven or so values for creating a backup/restore request, but that is optional and can/should be deferred.
There was a problem hiding this comment.
One more field that had to be duplicated was enough for me to fix it. The kubeobjects interface is intended to be a separate "library" and not have any dependencies on Ramen including its S3StoreProfile.
ShyamsundarR
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
An S3 store specified in a VRG's profiles has a certificate signed by a non-trusted authority and Kube object/resource protection is enabled but unable to store or retrieve data from it. See issue #921.
Proposed solution
Velero and OADP provide ways to specify CA certificates; both eventually specify them in a
BackupStorageLocation. Provide acaCertificatesinput in each S3 profile and pass it through to correspondingBackupStorageLocation.s3StoreAccessoranS3StoreProfileto avoid field duplicationTest results
End-to-end
shio-demofailover and failback completed successfully withcaCertificatesfield omitted froms3StoreProfiles