From a37e8120fc1a9776dadd7d27cf293c4e18412373 Mon Sep 17 00:00:00 2001 From: Cathy Zhu Date: Mon, 29 Jan 2018 18:50:22 -0800 Subject: [PATCH] Fix lightbox bug where panning results in carousel swipe (#13125) * Fix lightbox bug where panning results in carousel swipe * Add comment regarding event.preventDefault usage with gesture recognizers --- extensions/amp-image-viewer/0.1/amp-image-viewer.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/extensions/amp-image-viewer/0.1/amp-image-viewer.js b/extensions/amp-image-viewer/0.1/amp-image-viewer.js index 1e338accaf12..6b9bde6cf6f6 100644 --- a/extensions/amp-image-viewer/0.1/amp-image-viewer.js +++ b/extensions/amp-image-viewer/0.1/amp-image-viewer.js @@ -409,6 +409,10 @@ export class AmpImageViewer extends AMP.BaseElement { /** @private */ setupGestures_() { + // TODO (#12881): this and the subsequent use of event.preventDefault + // is a temporary solution to #12362. We should revisit this problem after + // resolving #12881 or change the use of window.event to the specific event + // triggering the gesture. this.gestures_ = Gestures.get( this.element, /* opt_shouldNotPreventDefault */true @@ -465,6 +469,7 @@ export class AmpImageViewer extends AMP.BaseElement { // Movable. this.unlistenOnSwipePan_ = this.gestures_ .onGesture(SwipeXYRecognizer, e => { + event.preventDefault(); this.onMove_(e.data.deltaX, e.data.deltaY, false); if (e.data.last) { this.onMoveRelease_(e.data.velocityX, e.data.velocityY);