Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Luminance algorithm doesn't recognize all images #2967

Closed
vincode-io opened this issue Apr 3, 2021 · 1 comment
Closed

Luminance algorithm doesn't recognize all images #2967

vincode-io opened this issue Apr 3, 2021 · 1 comment
Assignees
@vincode-io
Labels
iOS
Milestone
NetNewsWire 6.0

Comments

@vincode-io
Copy link
Member

vincode-io commented Apr 3, 2021 •
edited

The luminance algorithm misses some images because of their image format.
@vincode-io vincode-io added the iOS label Apr 3, 2021
@vincode-io vincode-io added this to the NetNewsWire 6.0 milestone Apr 3, 2021
@vincode-io vincode-io self-assigned this Apr 3, 2021
vincode-io added a commit that referenced this issue Apr 3, 2021
@vincode-io
Change the luminance algorithm so that we don't miss images in unexpe…
1874e0c 
…cted formats. Fixes #2967
@vincode-io
Copy link
Member Author

We now resize the image and normalize the image in-memory bitmap. This makes the algorithm faster and more accurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vincode-io vincode-io

Labels
iOS
Projects
None yet
Milestone
NetNewsWire 6.0
Development

No branches or pull requests
1 participant
@vincode-io