Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open article links in the NNW app browser #4135

Closed
dbarros opened this issue Oct 14, 2023 · 6 comments
Closed

Open article links in the NNW app browser #4135

dbarros opened this issue Oct 14, 2023 · 6 comments

Comments

@dbarros
Copy link

dbarros commented Oct 14, 2023

Some feeds only show the title and maybe a snippet of text in NNW when clicking on an article. I can then click on the title in NNW and it'll open it in my preferred system web browser, where I then get to see the complete article.

Would it be possible to instead have the full article be shown inside of NNW? For example, when I click on the link marked as (1), open the Bloomberg article in-place:

Screenshot 2023-10-14 at 12 12 57@2x

@brentsimmons
Copy link
Collaborator

Have you tried the Reader view? It’s the button in the toolbar to the left of the share button.

@dbarros
Copy link
Author

dbarros commented Oct 14, 2023

When I click the Reader View, the contents change to this:

Screenshot 2023-10-14 at 13 29 04@2x

What I was wanting (and I'm sorry if I'm not being clear), is to open any link that I click on that Techmeme NNW article view inside NNW. So looking at the screenshot above, if I click on Xbox Wire, I'd see this in NNW:

image

@stuartbreckenridge
Copy link
Member

stuartbreckenridge commented Oct 14, 2023

I played around briefly with enabling NNW to open in-article links in the app's WKWebView and encountered several issues.

First, there's no clean navigation back to the original article. You have to deselect and reselect it to return to where you were. Second, implementing webView.goBack() resulted in a white screen instead of returning to the feed article.

And related to the above—on a Mac at least—enabling the WebView to load the article enabled Forward / Back right-click options on the Webview. If you go to another article in the app, right-click and select Forward it actually loads the previously loaded external content (which was unexpected!).

I think that, while it would be possible to load external links inside NetNewsWire, that's not really what it's for. It's a reader, not a browser.

@dbarros
Copy link
Author

dbarros commented Oct 15, 2023

@stuartbreckenridge Thank you for responding in such detail. I guess my original query was a bit of hopeful thinking, knowing that the view is a WebView showing the article on the right.

The other reason was that, yes it's a reader, but it would be nice to be able do all my RSS reading in NNW itself -- which would include being able to see the full articles for those feeds that don't include it -- and not flip back-and-forth between it and a browser.

The issue you noticed where going Forward was taking you to the previously loaded external content could be avoided with some reset of the webview's browse history when switching articles. But now we'd be going down some hack-y rabbit hole.

@dbarros
Copy link
Author

dbarros commented Oct 18, 2023

@stuartbreckenridge @brentsimmons Using NNW on iOS, I realised that it's doing what I'd like the Mac version to do. Or am I seeing it differently? The issues with going to previously loaded external sites when going Forward would not happen if the webview was recreated, and thus started on a clean slate, when switching between articles.

@brentsimmons
Copy link
Collaborator

I wrote a blog post about this issue in 2019: https://inessential.com/2019/09/04/on_the_many_netnewswire_feature_requests

Since that blog post appeared, we did add a Reader view — which (most of the time) works to provide full content when an article is truncated in a feed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants