Skip to content

Refactored preTick to shouldTick #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RaphiMC merged 2 commits into from
Jul 31, 2025
Merged

Refactored preTick to shouldTick #33

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b21441
Refactored preTick to shouldTick
OakLoaf Jul 31, 2025
a995964
Added newline
OakLoaf Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/main/java/net/raphimc/noteblocklib/player/SongPlayer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ protected void createTickTask(final long initialDelay) {
*/
protected void tick() {
try {
if (!this.preTick()) {
if (!this.shouldTick()) {
return;
}
try {
Expand Down Expand Up @@ -248,8 +248,8 @@ protected void tick() {
*
* @return Whether the tick should be executed.
*/
protected boolean preTick() {
return true;
protected boolean shouldTick() {
return this.preTick();
}

/**
Expand Down Expand Up @@ -282,4 +282,15 @@ protected void onTickException(final Throwable e) {
this.stop();
}

/**
* Called before each tick (Even when paused).
*
* @return Whether the tick should be executed.
* @see #shouldTick()
*/
@Deprecated
protected boolean preTick() {
return true;
}

}