Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Better errors in controller / Add console.yml loading / console.yml default / Toolbar reinit after enter #9

Merged
merged 1 commit into from Jun 19, 2011

Conversation

Projects
None yet
2 participants
Contributor

nicodmf commented Jun 17, 2011

No description provided.

Is it necessary? the default configuration is already defined in Configuration, right?

Owner

nicodmf replied Jun 18, 2011

But theoretically, if you are a consolebundle-user, it's not recommended to modify an existing bundle. Configuring it is the goal, no?

I dislike to go back again and again in config.yml and a solution i found is (inside config.yml):

    imports:
        - { resource: params.ini }
        - { resource: @MyApplicationBundle/Resources/config/console.yml }

And inside console.yml; you are able to customize consolebundle without modifying a "vendor" bundle.

What do you think?

Owner

nicodmf replied Jun 18, 2011

I have use this solution in HiglightBundle. I think this solution is good too. The advantage is to conserve the same syntax, and to have an indication in general config file. But you lost the advantage to load automatically the config file.

So in fact, i think my problem isn't where is the config, but that's configuration another_process is a choice and not an order. The best when you install a bundle is to make nothing, and this work and if not, to have a clearly response which permit to know why, in the actual propose, the bundle can work, but user must test if this work, must change parameters and retest.
I would prefer to have a param with array or hash, which indicate a fallback solution by exemple :

execution: [ process, console ]

or

execution:
  primary: process
  fallback : console

You can always indicate in a flash message or in the response that the solution can't work in the primary execution and the fallback has been use.

@RapotOR RapotOR added a commit that referenced this pull request Jun 19, 2011

@RapotOR RapotOR Merge pull request #9 from nicodmf/master
Better errors in controller / Add console.yml loading / console.yml default / Toolbar reinit after enter
617e6c4

@RapotOR RapotOR merged commit 617e6c4 into RapotOR:master Jun 19, 2011

I modified all to false.
Consolebundle is usually used in the application being developed; I think.

$configs is an array of config. I replaced merging by adding $yaml_config to array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment