Added pander method for data.table class #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
data.table drops row name attributes and uses keys instead. While this is useful, it makes it a bit annoying to use with pander. This function grabs the first key (if there is one), removes it from the table, and sets it as the row name attribute.
| } | ||
| if(haskey(x)){ | ||
|
|
||
| row.names.dt <- test[[key(test)[1]]] |
There was a problem hiding this comment.
test should be x here, no? And also below.
|
Sorry for the long delay with my reply! First of all, thank you very much for this PR, indeed makes a lot of sense, but I've just added 2 comment above -- can you please address those? Also, I think this feature should be optional, or at least there should be a way to disable that, so can we have an extra argument for |
|
Whoops - good call on the I'll address those two points and make it optional. Thanks for the feedback. |
Removed test variables and made functionality actually work. Use setdiff for column selection.
daroczig
added a commit
that referenced
this pull request
Feb 14, 2016
Added pander method for data.table class
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
data.table drops row name attributes and uses keys instead. While this is useful, it makes it a bit annoying to use with pander. This function grabs the first key (if there is one), removes it from the table, and sets it as the row name attribute.
The
x <- x[ ,!(colnames(x) %in% key(test)[1])]is not the most elegant, but I wasn't sure if there was a better way to do this.