Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Removing File Extension #44

Merged
merged 1 commit into from Jun 3, 2013

Conversation

Projects
None yet
2 participants
Contributor

halpo commented May 31, 2013

Added file_path_sans_ext to Pandoc.convert to remove original file extension before adding output extension. Contributed by Andrew Redd.

This will make pander more consistent with other standards. It also makes it compatible to integrate into a vignette Engine since according to ?vignetteEngine

Currently the weave function, when operating on a file named
‘ ’ must produce a file named ‘.’.

@halpo halpo Added file_path_sans_ext to Pandoc.convert to remove original file
extension before adding output extension.  Contributed by Andrew Redd.
a0b8107
Owner

daroczig commented May 31, 2013

Thank you very much, Andrew! I will merge this pull request in a few days after doing my homework about ?vignetteEngine possibly on Monday or Tuesday.

Adding tools pkg to the Imports field in the DESCRIPTION file is also required if I'm right -- but that's a really minor issue, thanks again for letting me know about this.

@daroczig daroczig added a commit that referenced this pull request Jun 3, 2013

@daroczig daroczig Merge pull request #44 from halpo/fileext
Removing File Extension
3042751

@daroczig daroczig merged commit 3042751 into Rapporter:master Jun 3, 2013

1 check passed

default The Travis CI build passed
Details

@daroczig daroczig added a commit that referenced this pull request Jun 5, 2013

@daroczig daroczig keep file path #44 95209de
Owner

daroczig commented Jun 5, 2013

@halpo: it seems to me that the basename was not needed there. Could you please verify?
As Pandoc.convert now failed with file not found in current directory with open = TRUE. Of course I could tweak that part a bit, but only if the ?vignetteEngine would need a file name with an extension but without full path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment