Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeepAliveHandler not stopped when bot is logged out #1747

Closed
CraftSpider opened this issue Dec 2, 2018 · 1 comment
Closed

KeepAliveHandler not stopped when bot is logged out #1747

CraftSpider opened this issue Dec 2, 2018 · 1 comment

Comments

@CraftSpider
Copy link
Contributor

Though issue #309 was resolved, and the handler now closes on websocket close, the Client close() method calls self.ws.close() which isn't overiden, so the KeepAliveHandler thread is not stopped when the bot is closed or logged out

@CraftSpider
Copy link
Contributor Author

Fixed by #1748

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant