Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Webhook retry mechanic bug #2140
Currently, the mechanic allowing multiple attempts to send a webhook mechanic has a bug, that overwrites the request data with the response, rendering every attempt latter than the first one to send an incorrect request.
For example, sending executing multiple webhooks executions in short succession, triggering ratelimiting asynchronous sleep period.
We are supposed to still send the same request we tried to send prior to retrying.
Server response is fed back. This can cause multitude of errors, i.e 'Cannot send an empty message' due to last response from 'X-Ratelimit-Remaining' being empty prior to continuing.
Oh I see what you're referring to. It got conflated with the curl-related issue I've seen before, e.g. https://canary.discordapp.com/channels/336642139381301249/336642776609456130/576496506983677953