Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix public flags not updating #6315

Merged
merged 6 commits into from Jan 17, 2021
Merged

Fix public flags not updating #6315

merged 6 commits into from Jan 17, 2021

Conversation

LucasCoderT
Copy link
Contributor

Summary

Fixes #6288

_update_inner_user Now properly checks if the user public flag data has changed

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Copy link
Owner

@Rapptz Rapptz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation still doesn't work since the User._copy method does not copy over the _public_flags field.

discord/member.py Outdated Show resolved Hide resolved
discord/member.py Outdated Show resolved Hide resolved
discord/member.py Outdated Show resolved Hide resolved
Copy link
Owner

@Rapptz Rapptz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Rapptz Rapptz merged commit d7b41e0 into Rapptz:master Jan 17, 2021
@Rapptz Rapptz added this to the v1.7 milestone Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

public_flags.all() doesn't return updated badges.
2 participants