Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add read-only cached_messages property to Client #2086

Closed
wants to merge 2 commits into from

Conversation

@khazhyk
Copy link
Collaborator

commented Apr 15, 2019

Summary

For those of us who want access to this sweet trove of zero hop messages

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@khazhyk khazhyk force-pushed the khazhyk:cached_messages branch from 5d3199e to 08a1a72 Apr 15, 2019

Show resolved Hide resolved discord/utils.py
Show resolved Hide resolved discord/client.py Outdated

@khazhyk khazhyk force-pushed the khazhyk:cached_messages branch 3 times, most recently from 7afbf53 to 6308d54 Apr 15, 2019

add read-only cached_messages property to Client
For those of us who want access to this sweet trove of zero hop messages

@khazhyk khazhyk force-pushed the khazhyk:cached_messages branch from 6308d54 to 6da4cb4 Apr 15, 2019

@khazhyk khazhyk requested a review from Rapptz Apr 15, 2019

@Rapptz

Rapptz approved these changes Apr 15, 2019

@Rapptz Rapptz added this to the v1.1 milestone Apr 15, 2019

@NCPlayz

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

In migrating.rst, it is mentioned that Client.messages was removed, but would it be feasible to write that it has returned in some form?

@khazhyk

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 16, 2019

Updated migrating.rst. I don't have an rst renderer but it looks right...

def __reversed__(self):
return reversed(self.__proxied)

def index(self, value, *args, **kwargs):

This comment has been minimized.

Copy link
@bmintz

bmintz Apr 17, 2019

Contributor

Index takes no kwargs.

This comment has been minimized.

Copy link
@Rapptz

Rapptz Apr 18, 2019

Owner

This is a forwarding function so it's fine.

Show resolved Hide resolved docs/migrating.rst
@Rapptz

Rapptz approved these changes Apr 18, 2019

@Rapptz Rapptz added the rebased label Apr 18, 2019

@Rapptz Rapptz closed this Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.