Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for <:name:id> format for adding reactions #2095

Closed
wants to merge 1 commit into from

Conversation

@Vexs
Copy link
Contributor

commented Apr 17, 2019

Summary

This PR adds support for <:name:id> format in add_reaction.
It naively strips <> chars from the beginning and end, but no existing emojis have this, and custom emojis can't have <> in their name at all, much less at the beginning and end of the <:name:id> string.

As a note, discord accepts reactions with or without the leading :, so :name:id and a:name:id are perfectly acceptable.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Rapptz Rapptz closed this Apr 18, 2019

@Vexs Vexs deleted the Vexs:reaction_greater_less_than_symbols branch Apr 19, 2019

@Rapptz Rapptz added the rebased label May 10, 2019

@Rapptz Rapptz added this to the v1.1 milestone May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.