Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[commands] Add command.parents #2104

Closed
wants to merge 5 commits into from

Conversation

@Vexs
Copy link
Contributor

commented Apr 19, 2019

Summary

This PR adds the command.parents property, which returns list of all the parents a command has.
Also adjusts command.root_parent to use the new property.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Vexs added some commits Apr 19, 2019

Add command.parents
Make command.root_parent use new command.parents property
Move versionaddded string
Move entries back to original spot for cleaner diff
@BluePhoenixGame

This comment has been minimized.

Copy link
Contributor

commented Apr 20, 2019

Is it a list of command objects? And in what order is the list, like Is the root parent first or last in the list if you iterate through it. Could be good to document.

@Rapptz Rapptz added this to the v1.1 milestone Apr 20, 2019

@Rapptz Rapptz added the rebased label Apr 20, 2019

@Rapptz Rapptz closed this Apr 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.