Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add read method to attachment objects #2118

Closed
wants to merge 2 commits into from

Conversation

@Vexs
Copy link
Contributor

commented Apr 26, 2019

Summary

This adds a read method to Attachment objects.
Useful for when you want to read the attachment object and not save it to some file-like object.

Also noticed that the exceptions http.get_from_cdn raise are all hardcoded to say asset, despite usage in areas besides assets. Seems out of scope for this PR though.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
Show resolved Hide resolved discord/message.py

@Rapptz Rapptz added this to the v1.1 milestone Apr 30, 2019

@Rapptz Rapptz added the rebased label Apr 30, 2019

@Rapptz Rapptz closed this Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.