Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tasks] Return coro from before and after decorators #2154

Closed
wants to merge 1 commit into from

Conversation

@SnowyLuma
Copy link
Contributor

commented May 13, 2019

Summary

This PR allows registering the before or after coroutine to multiple tasks, or calling it outside of task context. Previously this was not possible as the decorators did not return the registered coroutine.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
@Rapptz

This comment has been minimized.

Copy link
Owner

commented May 14, 2019

Not sure how I missed this. Thanks.

@Rapptz Rapptz added the rebased label May 14, 2019

@Rapptz Rapptz added this to the v1.2 milestone May 14, 2019

@Rapptz Rapptz closed this May 14, 2019

@MinerChAI

This comment has been minimized.

Copy link

commented May 14, 2019

Also would be good to make command callable, so you can have multiple .command decorators for one callable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.