Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support team members data in application info #2239

Closed
wants to merge 14 commits into from

Conversation

@fourjr
Copy link
Contributor

fourjr commented Jun 21, 2019

Summary

New data has been added to /oauth2/applications/@me with team data (See discordapp/discord-api-docs#787 (comment))

This PR allows for access within the team and adds some shop-related attributes into AppInfo.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
discord/team.py Outdated Show resolved Hide resolved
Copy link
Contributor

NCPlayz left a comment

There's a few full stops missing in the docs, and I feel like the new enum should be documented.

discord/appinfo.py Show resolved Hide resolved
discord/team.py Show resolved Hide resolved
discord/team.py Outdated Show resolved Hide resolved
discord/appinfo.py Outdated Show resolved Hide resolved
discord/appinfo.py Outdated Show resolved Hide resolved
@BluePhoenixGame

This comment has been minimized.

Copy link
Contributor

BluePhoenixGame commented Jun 22, 2019

This looks good. But isn't it easier to make a new class and subclass AppInfo instead of having a lot of "If this applications is a game sold on Discord" in several attributes?

fourjr and others added 2 commits Jun 23, 2019
Co-Authored-By: BluePhoenixGame <38372706+BluePhoenixGame@users.noreply.github.com>
Co-Authored-By: Nadir Chowdhury <chowdhurynadir0@outlook.com>
discord/asset.py Outdated Show resolved Hide resolved
discord/asset.py Outdated Show resolved Hide resolved
discord/asset.py Outdated Show resolved Hide resolved
discord/appinfo.py Outdated Show resolved Hide resolved
discord/appinfo.py Outdated Show resolved Hide resolved
discord/ext/commands/bot.py Outdated Show resolved Hide resolved
discord/team.py Outdated Show resolved Hide resolved
discord/team.py Outdated Show resolved Hide resolved
discord/team.py Outdated Show resolved Hide resolved
discord/team.py Outdated Show resolved Hide resolved
fourjr and others added 4 commits Jun 26, 2019
Switch back to owner_id, minor code style improvements

Co-Authored-By: Danny <Rapptz@users.noreply.github.com>
Copy link
Owner

Rapptz left a comment

Almost there.

Amongst these changes the ones involving the owner_ids change I presented were misunderstood -- apologies.

discord/appinfo.py Outdated Show resolved Hide resolved
discord/appinfo.py Outdated Show resolved Hide resolved
discord/appinfo.py Outdated Show resolved Hide resolved
discord/appinfo.py Outdated Show resolved Hide resolved
discord/appinfo.py Outdated Show resolved Hide resolved
discord/appinfo.py Outdated Show resolved Hide resolved
discord/appinfo.py Outdated Show resolved Hide resolved
discord/ext/commands/bot.py Outdated Show resolved Hide resolved
discord/ext/commands/bot.py Outdated Show resolved Hide resolved
fourjr and others added 2 commits Jun 27, 2019
Co-Authored-By: Danny <Rapptz@users.noreply.github.com>
@Rapptz
Rapptz approved these changes Jun 29, 2019
Copy link
Owner

Rapptz left a comment

I still have a few nits with the PR but I'll fix them myself. Thanks!

@Rapptz Rapptz added the rebased label Jun 29, 2019
@Rapptz Rapptz closed this Jun 29, 2019
@Rapptz Rapptz added this to the v1.3 milestone Jun 29, 2019
@fourjr fourjr deleted the fourjr:teams-application-info branch Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.